dev
cvs co <whatever>
diff
s are with dev
Q: 1. Do I need CleanSlate/StarVMC/Rotations
? I did not find where they are used?
A: It is used in StarDb/AgiGeometry/CreateGeometry.h
and is Agi
related. Will not be needed once we move to
AgML
interface
Q: 2. Do I need StTrsMaker
? It is not used any more
A: Since StTrsMaker
is not deprecated the changes were made to keep code backwards compatible,
e.g. in pre-2008 era when it is used the code will still work.
Q: 3. I do not see TPCCATracker
. Is it really not modified? Geometry of iTPC is very different.
A: Does not require changes, changes in StiCA
will hande the difference in geometry
Q: 4. There is a lot of changes in Sti related to "Alignment" Is it related to iTPC?
A: No, they are not needed for iTPC and I removed them:
>> StRoot/Sti/StiKalmanTrackFinder.cxx
Bool_t StiKalmanTrackFinder::_DoAlignment = kFALSE;
. . .
// Aligment part
if (DoAlignment()) {
UInt_t sector = track->getTpcSector();
if (sector) {
const StTpcHit *tpcHit = dynamic_cast<const StTpcHit *>(stiHit->stHit());
if (tpcHit && tpcHit->sector() != sector) continue;
}
}
If you think there is more alignment related code please let me know and I will try to figure it out.
Q: 5 - 7 About changes in Sti
A: I only see tpcPadConfig
/iTPC related changes or minor cosmetic ones that I can easily reverse, please let me know if you see others.
Q: 8. There is a __NEW_TPCCATracker__
cpp flag. That means that NEW and OLD tracker should have different libraries.
Support is not easy. QUESTION: if _NEW_TPCCATracker__ is ON, old TPC will work properly?
A: This flag is actually in dev
not in my code and it is not relevant anymore. There must be no pre-interface-change remnants in my package
diff -b -r1.5 StiCATpcTrackerInterface.cxx
2d1
< #ifdef __NEW_TPCCATracker__
6,10d4
< #else /* ! __NEW_TPCCATracker__ */
< #include "TPCCATracker/AliHLTTPCCAGBHit.h"
< #include "TPCCATracker/AliHLTTPCCAGBTrack.h"
< #include "TPCCATracker/AliHLTTPCCAParam.h"
< #endif /* __NEW_TPCCATracker__ */
33d26
< #ifdef __NEW_TPCCATracker__
36,40c29
< #else /* ! __NEW_TPCCATracker__ */
< #include "TPCCATracker/Performance/AliHLTTPCCAStiPerformance.h"
< #include "TPCCATracker/Performance/AliHLTTPCCAMergerPerformance.h"
< #endif /* __NEW_TPCCATracker__ */
< #include "StDetectorDbMaker/St_tpcPadPlanesC.h"
Q: 9. In StdEdxY2Maker flag __Use_dNdx__
is ON, but official id OFF. For iTPC only ON or not
A: I commented out __Use_dNdx__
flag from
./StRoot/StdEdxY2Maker/StdEdxY2Maker.cxx
10. In StiDetectorBuilder.cxx
, removing:
nameP.ReplaceAll("HALL_1/CAVE_1/","");
nameP.ReplaceAll("TpcRefSys_1/","");
nameP.ReplaceAll("IDSM_1/","");
nameP.ReplaceAll("PXMO_1/","");
nameP.ReplaceAll("IBMO_1/","");
nameP.ReplaceAll("TPCE_1/","");
A: This is just related to printout only as far as I understand. This cam be reverted back. Actually only these were added to shorten the name
> nameP.ReplaceAll("TpcRefSys_1/","");
> nameP.ReplaceAll("IDSM_1/","");
> nameP.ReplaceAll("PXMO_1/","");
> nameP.ReplaceAll("IBMO_1/","");
> nameP.ReplaceAll("TPCE_1/","");
Q: 11. Some asserts
in Sti are commented out.
A: I only see two asserts
removed:
>> /afs/rhic.bnl.gov/star/packages/repository/StRoot/Sti/StiHit.cxx
assert( detector->insideL(dd,7,1.5));
Above one is activated sometimes and we need to understand it.
>> /afs/rhic.bnl.gov/star/packages/repository/StRoot/Sti/StiLocalTrackSeedFinder.cxx
diff -b -r2.44 StiLocalTrackSeedFinder.cxx
197,198c197
< if (fabs(dr) <=1.e-3) return false;
< assert (fabs(dr) >1.e-3); //// || dy==0. || dz==0.);
---
> if (fabs(dr) <1.e-3) return kFALSE;
Above one is just not used because of if() return;
in previous line.
assert
that I am trying to debug.AgiGeometry
but I wante to address these points first.throw()
is replaces with printouts) and I can reverse them easily.